Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set debezium num retries property to zero #37758

Merged
merged 4 commits into from
May 2, 2024
Merged

Set debezium num retries property to zero #37758

merged 4 commits into from
May 2, 2024

Conversation

rodireich
Copy link
Contributor

Configure debezium num retires to 0 (defaults to -1 which is unlimited)

@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 6:47am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 2, 2024
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres labels May 2, 2024
@rodireich rodireich requested a review from akashkulk May 2, 2024 06:33
@rodireich rodireich marked this pull request as ready for review May 2, 2024 06:33
@rodireich rodireich requested review from a team as code owners May 2, 2024 06:33
@rodireich
Copy link
Contributor Author

rodireich commented May 2, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/8919677651
✅ Successfully published Java CDK version=0.31.5!

@rodireich
Copy link
Contributor Author

rodireich commented May 2, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8919730361
✅ Successfully published Java CDK version=0.31.5!

akashkulk
akashkulk approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@akashkulk akashkulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - totally missed this!! Ahh I tried finding the documentation for debezium.retries but it isn't in any of the connector specific docs.

Could you link it in the PR?

@rodireich
Copy link
Contributor Author

Look for errors.max.retries in https://debezium.io/documentation/reference/stable/development/engine.html

@rodireich rodireich enabled auto-merge (squash) May 2, 2024 06:49
@rodireich rodireich merged commit f7f7f7e into master May 2, 2024
34 checks passed
@rodireich rodireich deleted the 4849-disable-retries branch May 2, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkulk akashkulk akashkulk approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodireich @akashkulk @octavia-squidington-iii