Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Insightly: Make Connector Compatible with Builder #38140

Merged
merged 6 commits into from
May 15, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 11, 2024
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:27am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 11, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 11, 2024 17:33
@btkcodedev
Copy link
Collaborator Author

Removed $parameter macros ✅
Embed schemas ✅

GitHub CI Green, Ready to merge ✅
image

@btkcodedev btkcodedev requested a review from girarda May 11, 2024 17:56
@@ -4,13 +4,13 @@ data:
sl: 100
allowedHosts:
hosts:
- TODO
- api.na1.insightly.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@@ -69,6 +69,7 @@ The connector is restricted by Insightly [requests limitation](https://api.na1.i

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------------------------------------------------------------------------ |
| 0.2.5 | 2024-05-30 | [38140](https://github.com/airbytehq/airbyte/pull/38140) | Make compatable with builder |
Copy link
Contributor

@girarda girarda May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's update the date to 05/14

Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@btkcodedev
Copy link
Collaborator Author

Change done

@girarda girarda merged commit ab0d60c into master May 15, 2024
34 checks passed
@girarda girarda deleted the btkcodedev/insightlyCompatable branch May 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/insightly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants