Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[airbyte-cdk] Python 3.11 dataclass compatibility #38846

Merged
merged 5 commits into from
Jun 3, 2024
Merged

[airbyte-cdk] Python 3.11 dataclass compatibility #38846

merged 5 commits into from
Jun 3, 2024

Conversation

natikgadzhi
Copy link
Contributor

What

Use dataclass fields with default_factory for 3.11 compatibility. Reimplements #33798 on top of current master.

How

Uses field with default_factory instead of const default values.

User Impact

None.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

TODO

  • We might want to do CDK testing on CI, but I'll check local tests and I just want to get this in so folks can run our connectors on 3.11.

@natikgadzhi
Python 3.11 dataclass compatibility
290d1d6 
Use dataclass fields with default_factory for 3.11 compatibility.
Reimplements #33798 on top of current master.
@natikgadzhi natikgadzhi requested a review from a team as a code owner June 2, 2024 00:41
@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 2:27am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jun 2, 2024
@natikgadzhi natikgadzhi changed the title Python 3.11 dataclass compatibility [airbyte-cdk] Python 3.11 dataclass compatibility Jun 2, 2024
@natikgadzhi natikgadzhi enabled auto-merge (squash) June 2, 2024 02:23
@natikgadzhi natikgadzhi requested a review from girarda June 2, 2024 16:08
girarda
girarda approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@natikgadzhi natikgadzhi merged commit dfd61c5 into master Jun 3, 2024
28 checks passed
@natikgadzhi natikgadzhi deleted the ng/python-3-11-fix branch June 3, 2024 19:14
@aaronsteers aaronsteers mentioned this pull request Jun 3, 2024
Closed
1 task
@aaronsteers
Copy link
Collaborator

Nice!

Thanks, @natikgadzhi ! 👏

@aaronsteers aaronsteers mentioned this pull request Jun 3, 2024
Merged
@natikgadzhi natikgadzhi mentioned this pull request Jun 3, 2024
Closed
@natikgadzhi
Copy link
Contributor Author

Heads up, if you're here because your connector of choice does not work on 3.11, it could be that it's using an outdated CDK. Here's a PR that maybe fixes Prestashop: #41656

@tcboles tcboles mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natikgadzhi @aaronsteers @girarda @octavia-squidington-iii