Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce logging noise #3909

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Reduce logging noise #3909

merged 4 commits into from
Jun 7, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jun 5, 2021 •
edited
Loading

What

  • This PR intends to reduce the amount of periodic loggings from the server.
  • See the screenshot below. Mosts of the information there is not useful:
    Screen Shot 2021-06-05 at 01 31 49
  • Need some help to dig into why some of the changes do not work.

How

  • Change periodic logging levels from info to debug.
  • Change temporal logging level to debug (not working).
  • Change non-error logs to debug level in RequestLogger (not working).

Recommended reading order

  • This is a short PR. Reviewing it only takes 30 seconds. No specific reading order is needed.

@tuliren tuliren marked this pull request as ready for review June 5, 2021 09:19
@auto-assign auto-assign bot requested review from cgardens and jrhizor June 5, 2021 09:19
jrhizor
jrhizor approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved % the RequestLogger change.

airbyte-commons/src/main/resources/log4j2.xml Outdated Show resolved Hide resolved
airbyte-scheduler/app/src/main/java/io/airbyte/scheduler/app/JobRetrier.java Show resolved Hide resolved
temporal/dynamicconfig/development.yaml Outdated Show resolved Hide resolved
temporal/dynamicconfig/development.yaml Outdated Show resolved Hide resolved
airbyte-server/src/main/java/io/airbyte/server/RequestLogger.java Outdated Show resolved Hide resolved
@tuliren tuliren merged commit cb3fb2a into master Jun 7, 2021
@tuliren tuliren deleted the liren/reduce-logging-noise branch June 7, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @jrhizor