Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Google Search Console version. #3917

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Bump Google Search Console version. #3917

merged 1 commit into from
Jun 8, 2021

Conversation

davinchia
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@davinchia
Copy link
Contributor Author

davinchia commented Jun 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-search-console-singer

🕑 source-google-search-console-singer https://github.com/airbytehq/airbyte/actions/runs/913141162
✅ source-google-search-console-singer https://github.com/airbytehq/airbyte/actions/runs/913141162

@davinchia
Copy link
Contributor Author

davinchia commented Jun 7, 2021 •
edited by github-actions bot
Loading

/publish connector=source-google-search-console-singer

❌ source-google-search-console-singer https://github.com/airbytehq/airbyte/actions/runs/913663090

@davinchia
Copy link
Contributor Author

davinchia commented Jun 7, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-search-console-singer

🕑 connectors/source-google-search-console-singer https://github.com/airbytehq/airbyte/actions/runs/913693178
✅ connectors/source-google-search-console-singer https://github.com/airbytehq/airbyte/actions/runs/913693178

@davinchia davinchia marked this pull request as ready for review June 7, 2021 07:58
@auto-assign auto-assign bot requested review from cgardens and jrhizor June 7, 2021 07:58
@davinchia davinchia merged commit 8a8dc7d into master Jun 8, 2021
@davinchia davinchia deleted the davinchia/release-google-search-console-correct-url branch June 8, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@cgardens cgardens Awaiting requested review from cgardens

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davinchia @marcosmarxm