Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AIRBYTE_ENTRYPOINT for kubernetes support #3973

Merged
merged 17 commits into from
Jun 9, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Jun 8, 2021

resolves most of the checks from #3903 :

  • set AIRBYTE_ENTRYPOINT in base image
  • set AIRBYTE_ENTRYPOINT for connectors with custom entrypoints
  • set AIRBYTE_ENTRYPOINT for normalization
  • bump/publish all image versions

I'll publish tonight or tomorrow morning

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

Can't wait for #1866 btw

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update templates? Checklist for updating templates is in the PR checklist template

@github-actions github-actions bot added area/worker Related to worker normalization labels Jun 9, 2021
@@ -1,7 +1,8 @@
FROM scratch

## TODO Add your dockerfile instructions here

## TODO uncomment the below line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call @sherifnada !

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=bases/base-python

🕑 bases/base-python https://github.com/airbytehq/airbyte/actions/runs/922304272
✅ bases/base-python https://github.com/airbytehq/airbyte/actions/runs/922304272

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/922305595
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/922305595

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/922307880
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/922307880

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-csv

🕑 connectors/destination-csv https://github.com/airbytehq/airbyte/actions/runs/922308150
✅ connectors/destination-csv https://github.com/airbytehq/airbyte/actions/runs/922308150

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/922310394
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/922310394

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/922310820
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/922310820

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/922311273
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/922311273

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/922311731
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/922311731

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/922312144
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/922312144

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/922312458
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/922312458

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/922312721
❌ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/922312721

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/922312997
❌ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/922312997

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/922313385
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/922313385

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/922313434
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/922313434

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-recharge run-tests=false

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/922772087
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/922772087

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-salesforce-singer run-tests=false

🕑 connectors/source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/922772538
✅ connectors/source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/922772538

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-zendesk-support-singer run-tests=false

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/922772900
✅ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/922772900

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-google-sheets run-tests=false

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/922773162
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/922773162

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-shopify run-tests=false

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/922773297
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/922773297

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

/publish connector=connectors/source-shopify-singer run-tests=false

🕑 connectors/source-shopify-singer https://github.com/airbytehq/airbyte/actions/runs/922773589
✅ connectors/source-shopify-singer https://github.com/airbytehq/airbyte/actions/runs/922773589

@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 9, 2021

Status of all of the connectors: https://docs.google.com/document/d/1ad6n6yhC9P4V7gyTB2G6lwpL5jVTWZj69s8xJDcWuxQ/edit

If the tests pass here I'm going to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment