Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrading-airbyte.md #39901

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Conversation

Adorism
Copy link
Contributor

@Adorism Adorism commented Jun 20, 2024

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 8:50pm

@nataliekwong
Copy link
Contributor

As we move away from supporting Docker, can we emphasize that we highly recommend the K8s directions as the
"golden path" for upgrading and place it ahead of the Docker instructions?

  • "Mandatory Intermediate Upgrade" seems like it should be a note and at the bottom, rather than at the top of the page

```bash
helm upgrade --install <RELEASE-NAME> airbyte/airbyte --values <VALUE.YAML> --version <HELM-APP-VERSION>
```
**If your current version of airbyte is < v0.32.0-alpha-patch-1, you first need to upgrade to this version before upgrading to any later version.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version doesn't seem to render correctly in this, should it be formatted differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I don't see special formatting on other examples where a version is named. But maybe it's better in the update with the collapsible section.

Copy link
Contributor

@nataliekwong nataliekwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the changes!

@Adorism Adorism merged commit be5977f into master Jun 28, 2024
28 checks passed
@Adorism Adorism deleted the Adorism-spot-check-upgrading-airbyte branch June 28, 2024 21:12
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants