-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Bamboo HR #5054
🎉 New Source: Bamboo HR #5054
Conversation
@haliva-firmbase thanks for the contribution! There anything you need help? |
@marcosmarxm @tuliren |
@haliva-firmbase oh! it's ready to review? can you change your PR from draft to ready? |
@marcosmarxm I asked in slack what should I do next and you guys told me that will CR my code and let me know if I need to change anything. sorry for the confusion. |
@haliva-firmbase, I am reviewing this PR. Would you mind giving me permission to your Airbyte fork? I'd like to push changes directly, such as resolving the conflicts. Otherwise, can you resolve the conflict in |
gave you permissions yesterday, you can also find me on slack (@orenhaliva) if you need anything else |
1608b4a
to
b2ef322
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haliva-firmbase, this PR looks good. I have made some changes to fix the integration test. It should be ready to go now.
After merging this PR, I will create another PR to publish it.
Thank you for your contribution!
(Also don't forget to remove me from your repo.)
What
New source for bamboo hr: https://documentation.bamboohr.com/docs
Solve this issue: #4931
Currently, it only supports Employees Directory API which is the only thing my company needs for now, in the future we might add additional APIs.
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secret
in the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command as documented here is passing.README.md
docs/SUMMARY.md
if it's a new connectordocs/integrations/<source or destination>/<name>
.docs/integrations/...
. See changelog exampledocs/integrations/README.md
contains a reference to the new connector/publish
command described here