Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 🎉 Source Dixa: Migrated to CI Sandbox, refactored code structure for future support #5367

Merged
merged 14 commits into from
Aug 18, 2021
Merged

📝 🎉 Source Dixa: Migrated to CI Sandbox, refactored code structure for future support #5367

merged 14 commits into from
Aug 18, 2021

Conversation

bazarnov
Copy link
Collaborator

What

#4667 - Use Dixa Sandbox in CI

How

  • refactored code structure for future support and extendability for new possible streams
  • edited unit-tests
  • edited acceptance-tests

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Credentials added to Github CI. Instructions.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov self-assigned this Aug 12, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 12, 2021
@bazarnov bazarnov linked an issue Aug 12, 2021 that may be closed by this pull request
Use Dixa Sandbox in CI #4667
Closed
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 12, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-dixa

🕑 connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1123925878
✅ connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1123925878

@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 12:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 15, 2021 16:08 Inactive
@bazarnov bazarnov requested a review from antixar August 15, 2021 16:12
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 11:35 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 12:28 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 13:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 13:13 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 13:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 13:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 14:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 14:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 16:21 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 16, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-dixa

🕑 connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1136210315
✅ connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1136210315

@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 16:33 Inactive
@bazarnov bazarnov requested a review from Phlair August 16, 2021 20:37
sherifnada
sherifnada approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-dixa

🕑 connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1144193959
✅ connectors/source-dixa https://github.com/airbytehq/airbyte/actions/runs/1144193959

@jrhizor jrhizor temporarily deployed to more-secrets August 18, 2021 18:15 Inactive
@bazarnov bazarnov merged commit 0f55bf6 into master Aug 18, 2021
@bazarnov bazarnov deleted the bazarnov/4667-dixa-sandbox-in-ci branch August 18, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antixar antixar antixar approved these changes

@sherifnada sherifnada sherifnada approved these changes

@midavadim midavadim midavadim approved these changes

@Phlair Phlair Awaiting requested review from Phlair

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/dixa connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Dixa Sandbox in CI
6 participants
@bazarnov @midavadim @sherifnada @antixar @jrhizor @karinakuz