Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Added UserLocationReport to Google Ads #5423

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

MaxKrog
Copy link
Contributor

@MaxKrog MaxKrog commented Aug 16, 2021

Fixes issue #5412

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 16, 2021
@marcosmarxm
Copy link
Member

thanks @MaxKrog I'm going review later today. It's possible to run ./gradlew format to adjust some formatting styles?

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just formatting =)

Comment on lines 41 to 43



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

@MaxKrog
Copy link
Contributor Author

MaxKrog commented Aug 16, 2021

LGTM just formatting =)

Will fix tomorrow. Do i also need to bump connector version?

@MaxKrog
Copy link
Contributor Author

MaxKrog commented Aug 17, 2021

Fixed formatting and bumped connector version to 0.1.6.

Apologies for force-pushing updates. Had issues with the config in git.

Are we good to go?:) @marcosmarxm

@marcosmarxm marcosmarxm changed the title Added UserLocationReport to Google Ads 🎉 Added UserLocationReport to Google Ads Aug 18, 2021
@marcosmarxm marcosmarxm merged commit 96c2d2a into airbytehq:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants