Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Oracle normalization #5562

Merged
merged 46 commits into from
Sep 7, 2021
Merged

🎉 Oracle normalization #5562

merged 46 commits into from
Sep 7, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Aug 22, 2021 •
edited
Loading

What

Adds Oracle Normalization 🚀

How

Implement oracle dbt in normalization module.

Recommended reading order

  1. x.java
  2. y.python

Checklist

  • Merge Destination Oracle: change table limit and format record data #5542 to use the destination connector with 128 table limit and formatted records.
  • Create an AWS Oracle RDS instance for tests (both destination connector and normalization need it)
  • Add secrets to Github
  • Run tests
  • Change destination connector oracle to write airbyte columns in ", eg: "_airbyte_data"
  • Refactor code to remove _ for Oracle
  • Refactor SQL functions to work for every destination
  • Update docs saying Oracle normalization doesnt support unnesting
  • Publish new normalization version

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 23, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1159974101
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1159974101

@jrhizor jrhizor temporarily deployed to more-secrets August 23, 2021 19:34 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 23, 2021 •
edited
Loading

tests are blocked by #5542

@jrhizor jrhizor temporarily deployed to more-secrets August 24, 2021 18:53 Inactive
@github-actions github-actions bot added area/connectors Connector related issues CDK Connector Development Kit labels Aug 24, 2021
@jrhizor jrhizor temporarily deployed to more-secrets August 24, 2021 20:50 Inactive
@github-actions github-actions bot removed area/connectors Connector related issues CDK Connector Development Kit labels Aug 24, 2021
@jrhizor jrhizor temporarily deployed to more-secrets August 24, 2021 21:52 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 25, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1164987155
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1164987155

@jrhizor jrhizor temporarily deployed to more-secrets August 25, 2021 03:01 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 25, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1165165828
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1165165828

@jrhizor jrhizor temporarily deployed to more-secrets August 25, 2021 04:26 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 25, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1166490760
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1166490760

@github-actions github-actions bot added the area/worker Related to worker label Sep 2, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 2, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1195507217
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1195507217

@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 19:36 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 7, 2021 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1209803559
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1209803559

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 14:26 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 7, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1209982756
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1209982756

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 15:16 Inactive
@marcosmarxm marcosmarxm merged commit 589d535 into master Sep 7, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/normalization-oracle branch September 7, 2021 19:39
@marcosmarxm marcosmarxm mentioned this pull request Sep 8, 2021
Closed
@jrhizor jrhizor mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheDuong ChristopheDuong ChristopheDuong approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation area/worker Related to worker normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosmarxm @ChristopheDuong @jrhizor