Add API endpoint to get oauth request/consent #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
ChristopheDuong
commented
Aug 27, 2021
Comment on lines
2866
to
2873
| # OAuth | ||
| OAuthConsentRead: | ||
| type: object | ||
| required: | ||
| - consentUrl | ||
| properties: | ||
| consentUrl: | ||
| type: string |
There was a problem hiding this comment.
BTW, should the OAuthConsentRead returned with the connector's definition id that was provided as input too?
In that case, we'd have to have a OAuthSourceConsentRead & OAuthDestinationConsentRead?
There was a problem hiding this comment.
I don't think so. The UI has access to that information when it receives this response.
sherifnada
reviewed
Aug 27, 2021
| @@ -1182,6 +1184,52 @@ paths: | |||
| $ref: "#/components/responses/NotFoundResponse" | |||
| "422": | |||
| $ref: "#/components/responses/InvalidInputResponse" | |||
| /v1/source_oauths/get_oauth_consent: | |||
| post: | |||
There was a problem hiding this comment.
it feels like this should be a GET so the server redirects the user directly, but it would break our API convention. With this being a post, the UI would need to redirect the user. NBD I think.
Comment on lines
2866
to
2873
| # OAuth | ||
| OAuthConsentRead: | ||
| type: object | ||
| required: | ||
| - consentUrl | ||
| properties: | ||
| consentUrl: | ||
| type: string |
There was a problem hiding this comment.
I don't think so. The UI has access to that information when it receives this response.
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
…e into chris/oauth-request-api
This was
linked to
issues
Aug 31, 2021
sherifnada
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #5639 and #5640
The endpoints in this PR will be leveraged as part of this larger flow
Recommended reading order
config.yamlConfigurationApi.java