Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data volume in docker-compose file #5715

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Aug 27, 2021

What

2021-08-27 19:03:53 INFO i.a.c.EnvConfigs(getEnvOrDefault):335 - {workspace_app_root=/tmp/workspace/scheduler/logs} - DOCKER_NETWORK not found or empty, defaulting to host
Exception in thread "main" java.lang.RuntimeException: Storage root does not exist: /data
	at io.airbyte.config.persistence.FileSystemConfigPersistence.hasExistingConfigs(FileSystemConfigPersistence.java:72)
	at io.airbyte.config.persistence.ConfigPersistenceBuilder.create(ConfigPersistenceBuilder.java:71)
	at io.airbyte.config.persistence.ConfigPersistenceBuilder.getDbPersistence(ConfigPersistenceBuilder.java:62)
	at io.airbyte.scheduler.app.SchedulerApp.main(SchedulerApp.java:216)

How

add volume mapping in docker-compose

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@marcosmarxm marcosmarxm merged commit 32c2a6b into master Aug 27, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/docker-compose-data-dir branch August 27, 2021 21:04
tuliren added a commit that referenced this pull request Aug 28, 2021
This reverts commit 32c2a6b. Since we have a new release, v0.29.13-alpha, this temporary fix is no longer needed.
tuliren added a commit that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants