Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Typeform: add support for multiple choices in responses #5799

Merged
merged 4 commits into from
Sep 6, 2021
Merged

🐛Source Typeform: add support for multiple choices in responses #5799

merged 4 commits into from
Sep 6, 2021

Conversation

zuc
Copy link
Contributor

@zuc zuc commented Sep 2, 2021 •
edited
Loading

What

Add support for multiple choices in Typeform responses

How

Missing

Recommended reading order

N/A

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@zuc @yaroslav-dudar
fix(connectors/source-typeform): add support for multiple choices in …
9be1a3c 
…responses

Co-authored-by: Yaroslav Dudar <flayingfog@gmail.com>
Signed-off-by: Michele Zuccala <michele@zuccala.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 2, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 4, 2021
@yaroslav-dudar
Copy link
Contributor

yaroslav-dudar commented Sep 4, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1201162979
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1201162979

@jrhizor jrhizor temporarily deployed to more-secrets September 4, 2021 15:08 Inactive
@yaroslav-dudar yaroslav-dudar changed the title Source Typeform: add support for multiple choices in responses 🐛Source Typeform: add support for multiple choices in responses Sep 4, 2021
marcosmarxm
marcosmarxm approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @zuc

@marcosmarxm
Copy link
Member

marcosmarxm commented Sep 6, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1206820591
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1206820591

@jrhizor jrhizor temporarily deployed to more-secrets September 6, 2021 17:40 Inactive
@marcosmarxm marcosmarxm merged commit fe38f69 into airbytehq:master Sep 6, 2021
@jrhizor jrhizor mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zuc @yaroslav-dudar @marcosmarxm @jrhizor