Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 BigQuery Denormalized Destination: Support for more bigquery types through the format annotation #6145

Conversation

cptjacky
Copy link
Contributor

@cptjacky cptjacky commented Sep 16, 2021

What

Closes #6142

When using the BigQuery Denormalized Destination, the generated schema should support the date/datetime types when possible (using the "format" key in the json spec).

My Java is a bit rusty (its been a few years) and I'm rather new to Airbyte, so I'm open to any idea or suggestion to improve this!

I wasn't sure where to put this in the Pull Request, but I'm not sure what the impact of this change is for existing setups and what Airbyte's policy is when it comes to breaking changes!

How

When generating the BigQuery schema, read the format key of the JSON node, and override the original type with a better suited type.

Recommended reading order

Reading BigQueryDenormalizedDestinationTest.java first can help you understand the type of data & the expected schema.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 16, 2021
@cptjacky cptjacky force-pushed the 6142/destination-bigquery-denormalized-format-types branch from 268a571 to 3d4cd4d Compare September 16, 2021 15:09
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 16, 2021
@marcosmarxm marcosmarxm self-assigned this Sep 16, 2021
@marcosmarxm
Copy link
Member

thanks @cptjacky for this contribution! We're going to review later Monday

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Denormalized Destination: Support for Date/Datetime types through the format annotation
5 participants