🎉 BigQuery Denormalized Destination: Support for more bigquery types through the format annotation #6145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #6142
When using the BigQuery Denormalized Destination, the generated schema should support the date/datetime types when possible (using the "format" key in the json spec).
My Java is a bit rusty (its been a few years) and I'm rather new to Airbyte, so I'm open to any idea or suggestion to improve this!
I wasn't sure where to put this in the Pull Request, but I'm not sure what the impact of this change is for existing setups and what Airbyte's policy is when it comes to breaking changes!
How
When generating the BigQuery schema, read the
format
key of the JSON node, and override the original type with a better suited type.Recommended reading order
Reading
BigQueryDenormalizedDestinationTest.java
first can help you understand the type of data & the expected schema.Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here