Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google ads specs #6565

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Fix google ads specs #6565

merged 2 commits into from
Oct 1, 2021

Conversation

ChristopheDuong
Copy link
Contributor

What

There is no oneOf in google ads credentials object

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 30, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 30, 2021 10:45 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Sep 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1290698391
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1290698391
🐛 Binary file (standard input) matches

@jrhizor jrhizor temporarily deployed to more-secrets September 30, 2021 10:51 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Sep 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1291059245
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1291059245
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75     50    33%
	 source_google_ads/google_ads.py               65     10    85%
	 source_google_ads/source.py                   35     15    57%
	 source_google_ads/streams.py                  77      5    94%
	 --------------------------------------------------------------
	 TOTAL                                        254     80    69%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75      6    92%
	 source_google_ads/google_ads.py               65      7    89%
	 source_google_ads/source.py                   35     22    37%
	 source_google_ads/streams.py                  77     15    81%
	 --------------------------------------------------------------
	 TOTAL                                        254     50    80%

@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 30, 2021 12:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 30, 2021 12:42 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Oct 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1294235307
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1294235307
🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1294235307
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1294235307

@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 08:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 08:43 Inactive
@ChristopheDuong ChristopheDuong merged commit 341d105 into master Oct 1, 2021
@ChristopheDuong ChristopheDuong deleted the chris/fix-google-ads-specs branch October 1, 2021 09:46
@jrhizor jrhizor mentioned this pull request Oct 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@ChristopheDuong @schlattk
Fix google ads specs (airbytehq#6565)
51828c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopheDuong @sherifnada @jrhizor