Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ssh private key format for ssh tunnels #6585

Merged
merged 6 commits into from
Oct 4, 2021

Conversation

airbyte-jenny
Copy link
Contributor

What

Clarify ssh private key format for ssh tunneling with connectors.

How

Modifies the connector spec field description to tell the user the key format, and show the command to create it. Updates related docs to clarify as well.

@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets September 30, 2021 19:42 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 30, 2021
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets September 30, 2021 19:55 Inactive
@airbyte-jenny airbyte-jenny requested review from cgardens and sherifnada and removed request for cgardens September 30, 2021 19:56
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets September 30, 2021 19:59 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

is the version bump going to happen in this PR or a follow up?

docs/integrations/sources/oracle.md Outdated Show resolved Hide resolved
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets October 4, 2021 17:28 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets October 4, 2021 17:44 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets October 4, 2021 17:51 Inactive
@airbyte-jenny airbyte-jenny merged commit 2e5fbba into master Oct 4, 2021
@airbyte-jenny airbyte-jenny deleted the airbyte-jenny/ssh-key-docs-6514 branch October 4, 2021 18:59
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Clarify ssh private key format for ssh tunnels
* Improved SSH Tunnel key generation steps, fixed formatting
* Modified wording 'app' to 'connector' for consistency
* Ran format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants