-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source GoogleAds: add end_date to config #8669
Source GoogleAds: add end_date to config #8669
Conversation
airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
@iberchid please run unit tests to validate your change also please add a new unit test with a specific end_date to validate your changes. |
@sherifnada can you review the UX modification this PR makes? |
Hi @marcosmarxm , Thanks for your comments, I updated the scripts according to your recommendations. I also ran existing unit tests and added a few more: |
@iberchid can you solve the conflicts and make sure the |
@iberchid can you solve the conflicts? and share the output from the command above |
Instanciate IncrementalGoogleAdsStream in tests + add missing line between functions
remove extra hashtag
Hello @marcosmarxm , I resolved the conflicts and reran the unit tests both in 1-Locally in 2- Gradle: The failures are related to |
You need to create a folder called |
Here it is @marcosmarxm : |
Hi @marcosmarxm , what is the status of this PR? Are there any other TODOs left for me? |
What
Relates to issue #8666
How
Added end_date to spec and updated the source.py and streams.py files to allow for setting an end_date.
Recommended reading order
spec.json
source.py
streams.py
🚨 User Impact 🚨
No changes, because when the parameter is not provided the default value is used which is identical to the previous implementation.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesThis change is