Db2 source: discover only permitted tables #9875

sashaNeshcheret · 2022-01-28T16:44:52Z

What

User without permissions could discover tables and schemas

How

During discovery we keep only tables that was fetched with right select permissions

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…b2-user-permissions # Conflicts: # airbyte-integrations/connectors/source-db2/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/Db2SourceAcceptanceTest.java

etsybaev

Please do not forget to pass the PR's checklist

sashaNeshcheret · 2022-02-01T10:52:17Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1777811587
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1777811587
No Python unittests run

alexandr-shegeda

LGTM. we can proceed with publishing and merging without airbyte review

sashaNeshcheret · 2022-02-01T12:09:17Z

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778144737
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778144737
No Python unittests run

sashaNeshcheret · 2022-02-01T12:56:09Z

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778347280
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778347280
No Python unittests run

sashaNeshcheret · 2022-02-01T12:56:17Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1778347386
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1778347386
No Python unittests run

sashaNeshcheret · 2022-02-01T13:36:14Z

/publish connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1778556045
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1778556045

sashaNeshcheret · 2022-02-01T13:36:38Z

/publish connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778558226
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1778558226

db2 source: discover only permitted tables

d56b566

github-actions bot added the area/connectors Connector related issues label Jan 28, 2022

sashaNeshcheret changed the title ~~db2 source: discover only permitted tables~~ DRAFT: db2 source: discover only permitted tables Jan 28, 2022

db2 source: handle case for user without permitted tables

2bb2e00

sashaNeshcheret temporarily deployed to more-secrets January 31, 2022 10:38 Inactive

Merge remote-tracking branch 'origin/master' into omneshcheret/8171-d…

a27f8f1

…b2-user-permissions # Conflicts: # airbyte-integrations/connectors/source-db2/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/Db2SourceAcceptanceTest.java

sashaNeshcheret temporarily deployed to more-secrets January 31, 2022 10:45 Inactive

db2 source: sonar fixes

9ede0ed

sashaNeshcheret requested a review from etsybaev January 31, 2022 10:52

sashaNeshcheret changed the title ~~DRAFT: db2 source: discover only permitted tables~~ Db2 source: discover only permitted tables Jan 31, 2022

sashaNeshcheret temporarily deployed to more-secrets January 31, 2022 10:55 Inactive

db2 source: format fixes

2e8bada

sashaNeshcheret linked an issue Jan 31, 2022 that may be closed by this pull request

Source DB2: Schemas and tables where the connected user doesn't have privileges appear on Airbyte UI #8171

Closed

etsybaev approved these changes Feb 1, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 10:54 Inactive

alexandr-shegeda approved these changes Feb 1, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 12:11 Inactive

sashaNeshcheret added 2 commits February 1, 2022 14:53

db2 source: sonar fixes

2cefd69

db2 source: bump versions

fa4eb9a

github-actions bot added the area/documentation Improvements or additions to documentation label Feb 1, 2022

sashaNeshcheret temporarily deployed to more-secrets February 1, 2022 12:57 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 12:58 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 13:38 Inactive

db2 source: generated seeds

55519e7

sashaNeshcheret temporarily deployed to more-secrets February 1, 2022 14:47 Inactive

sashaNeshcheret merged commit 98b5aab into master Feb 1, 2022

sashaNeshcheret deleted the omneshcheret/8171-db2-user-permissions branch February 1, 2022 15:49

octavia-squidington-iii mentioned this pull request Feb 1, 2022

Bump Airbyte version from 0.35.14-alpha to 0.35.15-alpha #9981

Merged

sashaNeshcheret mentioned this pull request Feb 8, 2022

JDBC sources: update for sources that not have permissions issues #10173

Merged

40 tasks

tuliren mentioned this pull request Feb 24, 2022

🐛 Source Postgres: cannot retrieve all tables accessible to the user #10649

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Db2 source: discover only permitted tables #9875

Db2 source: discover only permitted tables #9875

sashaNeshcheret commented Jan 28, 2022 •

edited

Loading

etsybaev left a comment

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment •

edited

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

Db2 source: discover only permitted tables #9875

Db2 source: discover only permitted tables #9875

Conversation

sashaNeshcheret commented Jan 28, 2022 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

etsybaev left a comment

Choose a reason for hiding this comment

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

alexandr-shegeda left a comment • edited Loading

Choose a reason for hiding this comment

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 1, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Jan 28, 2022 •

edited

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment •

edited

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2022 •

edited by github-actions bot

Loading