-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove invalid list
RBAC for pod/log
resource
#621
base: main
Are you sure you want to change the base?
Conversation
Removing invalid verb: list, from the pods/log resource in airflow role. List is not a valid verb for pods/log as per the kubernetes api spec. It appears that the only valid verb for pods/log is get, see: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#get-read-log-of-the-specified-pod Signed-off-by: John Arnesen <arnesenfamily@gmail.com>
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
list
RBAC for pod/log
resource
@arnesenfamily thanks for the PR, it looks great! I have added this to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnesenfamily sorry for this, but I can see the DCO bot is complaining that you signed off the commit with the wrong name: Expected "arnesenfamily [arnesenfamily@users.noreply.github.com](mailto:arnesenfamily@users.noreply.github.com)", but got "John Arnesen [arnesenfamily@gmail.com](mailto:arnesenfamily@gmail.com)".
Additionally, the semantic PR bot is complaining that your commit message needs to be semantic, please rename it to: fix: remove invalid `list` RBAC for `pod/log` resource
Can you please force push and fix this?
What issues does your PR fix?
What does your PR do?
list
from thepods/log
resource of the airflow RBAC Role. This is becauselist
is not a valid verb forpods/log
as per the Kubernetes API spec, it appears that the only valid verb forpods/log
isget
.