Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid list RBAC for pod/log resource #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arnesenfamily
Copy link

@arnesenfamily arnesenfamily commented Jun 28, 2022

What issues does your PR fix?

  • N/A

What does your PR do?

  • Removing invalid verb list from the pods/log resource of the airflow RBAC Role. This is because list is not a valid verb for pods/log as per the Kubernetes API spec, it appears that the only valid verb for pods/log is get.

Removing invalid verb: list, from the pods/log resource in airflow role. List is not a valid verb for pods/log as per the kubernetes api spec. It appears that the only valid verb for pods/log is get, see: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#get-read-log-of-the-specified-pod

Signed-off-by: John Arnesen <arnesenfamily@gmail.com>
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Aug 31, 2022
@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Sep 1, 2022
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Sep 1, 2022
@thesuperzapper thesuperzapper changed the title Update airflow-role.yaml fix: remove invalid list RBAC for pod/log resource Sep 1, 2022
@thesuperzapper
Copy link
Member

@arnesenfamily thanks for the PR, it looks great!

I have added this to the 8.6.1 milestone.

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Sep 1, 2022
thesuperzapper
thesuperzapper previously approved these changes Sep 1, 2022
@thesuperzapper thesuperzapper removed the status/ready-to-merge status - this will be merged into next release label Apr 6, 2023
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnesenfamily sorry for this, but I can see the DCO bot is complaining that you signed off the commit with the wrong name: Expected "arnesenfamily [arnesenfamily@users.noreply.github.com](mailto:arnesenfamily@users.noreply.github.com)", but got "John Arnesen [arnesenfamily@gmail.com](mailto:arnesenfamily@gmail.com)".

Additionally, the semantic PR bot is complaining that your commit message needs to be semantic, please rename it to: fix: remove invalid `list` RBAC for `pod/log` resource

Can you please force push and fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants