moving from zlib to minizlib

[makrsmark]

No description provided.

[makrsmark]

will see if this works against the SPA before merging this PR

[makrsmark]

@andermatt64 added you because i wanted to make sure this is ok... i think it is, but i'm not going to pretend to know this code

[kevinelliott]

@andermatt64

[makrsmark]

used npm link to have a local override - looks like it's still the same issue, not a fix

Module not found: Error: Can't resolve 'zlib' in 'C:\Users\marks\code\acars-decoder-typescript\node_modules\minizlib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
        - install 'browserify-zlib'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "zlib": false }

Will keep open as the partial decoding might be good, but if this is closed, i won't be sad

[kevinelliott]

used npm link to have a local override - looks like it's still the same issue, not a fix

Module not found: Error: Can't resolve 'zlib' in 'C:\Users\marks\code\acars-decoder-typescript\node_modules\minizlib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
        - install 'browserify-zlib'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "zlib": false }

Ahh worth a try. Hopefully we can figure that out sooner than later.

[kevinelliott]

@makrsmark What do you think? Is this still up to date? :)

[makrsmark]

I think it's useful as it seems to decode a little more. If we want it, I can fix conflicts. Otherwise, we can just close without merging.

[kevinelliott]

I'd say we merge it (after resolving conflicts), if you still think there is value here.