Turn LED indicate wifi failed, cloud failed and get cloud configuration failed to off #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-4711
reviewed
May 15, 2024
| if (configuration.isOfflineMode() == false) { | ||
| if (wifiConnector.isConnected() == false) { | ||
| state = AgStateMachineWiFiLost; | ||
| } else if (apiClient.isFetchConfigureFailed()) { |
There was a problem hiding this comment.
propose to name the method isFetchConfigurationFailed() or only fetchConfigurationFailed() would be fine too
nick-4711
reviewed
May 15, 2024
| if (wifiConnector.isConnected() == false) { | ||
| state = AgStateMachineWiFiLost; | ||
| } else if (apiClient.isFetchConfigureFailed()) { | ||
| stateMachine.displaySetAddToDashBoard(); |
There was a problem hiding this comment.
I haven't looked at the implementation of isFetchConfigurationFailed() but in this context I can think of these cases where the message can be misleading
- The fetch failed because of some internet issue, e.g. timeout
- The fetch failed because of server overload or backend down (e.g. 503 is returned)
I think we should display this message only if the server returns a 400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.