Zstd streaming and Hadoop Codec #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
zstd-streaming
branch
3 times, most recently
from
2decb38
to
e6c2f37
Compare
|
This appears to resolve #112 |
This was referenced Aug 28, 2022
Closed
|
I'd love to see this merged and released; we're holding off on evaluating this library until the streaming API is available. |
martint
reviewed
Jan 31, 2023
| throws IOException | ||
| { | ||
| XxHash64 hash = new XxHash64(seed); | ||
| byte[] buffer = new byte[8192]; |
There was a problem hiding this comment.
I coppied this from Slice https://github.com/airlift/slice/blob/master/src/main/java/io/airlift/slice/XxHash64.java#L179
src/main/java/io/airlift/compress/zstd/ZstdFrameDecompressor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/airlift/compress/zstd/ZstdFrameDecompressor.java
Outdated
Show resolved
Hide resolved
dain
commented
Feb 19, 2023
| throws IOException | ||
| { | ||
| XxHash64 hash = new XxHash64(seed); | ||
| byte[] buffer = new byte[8192]; |
There was a problem hiding this comment.
I coppied this from Slice https://github.com/airlift/slice/blob/master/src/main/java/io/airlift/slice/XxHash64.java#L179
martint
reviewed
Feb 25, 2023
src/main/java/io/airlift/compress/zstd/ZstdIncrementalFrameDecompressor.java
Outdated
Show resolved
Hide resolved
martint
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #112