Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option.allowedValues() does not appear to be respected #26

Closed
rvesse opened this issue Nov 13, 2013 · 2 comments
Closed

Option.allowedValues() does not appear to be respected #26

rvesse opened this issue Nov 13, 2013 · 2 comments

Comments

@rvesse
Copy link

rvesse commented Nov 13, 2013

The Option annotation has a allowedValues() that can be set but this does not appear to actually get honoured by the parser

The only place this is used is when OptionMetadata is populated by MetadataLoader and then the only place that OptionMetadata.getAllowedValues() is used is in the Parser where it only gets used to display an error message
rvesse referenced this issue in rvesse/airline Nov 13, 2013
@rvesse
Fix Issue #26
1186aa6 
Modifies Parser so that the allowedValues for an option are honoured and
an error thrown on illegal values
@rvesse
Copy link
Author

rvesse commented Nov 13, 2013

I've open a pull request with a proposed fix for this, see Pull Request #27

@rvesse rvesse mentioned this issue Nov 13, 2013
Merged
@rvesse
Copy link
Author

rvesse commented Sep 10, 2018

Closing as long since resolved in my fork

@rvesse rvesse closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rvesse