Fix Issue #26 #27
Closed
Fix Issue #26 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dain Copyright header should now be Apache 2 like the rest of airline |
|
I have brought my fork back up to date with master and this fix can now be merged again |
|
I've now forked my own variant of airline with this and various other changes I wanted so I am closing this pull request since this is no longer a self-contained feature in my fork |
|
Why did this never get fixed? It's causing me problems right now... |
|
@cread My fork at http://github.com/rvesse/airline has this and many other fixes that have never been accepted here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies Parser so that the allowedValues for an option are honoured and
an error thrown on illegal values
Includes unit test which verifies the improve behaviour