Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F REQ] ADT to correctly sign dynamic frameworks included packaged with iOS app #10

Closed
tuarua opened this issue Jul 22, 2017 · 9 comments

Comments

@tuarua
Copy link

tuarua commented Jul 22, 2017

Problem Description

To be able to build ANEs using Swift developers must use dynamic frameworks.
These frameworks when included are not signed correctly by adt and a complex bash based workflow is needed to package the final ipa file.

The current workflow workaround is

  1. Sign frameworks when building ANE in Xcode
  2. Resign frameworks using codesign bash script
  3. Package AIR ipa using adt, including any framework files
  4. Resign AIR ipa using bash script

Known Workarounds

I have produced an AIR based tool to manage the resigning of Frameworks and AIR app but it's not ideal
https://github.com/tuarua/AIR-iOS-Packager

@myflashlab
Copy link

Surely a +1 on this one. To add to what @tuarua described, I must say that as the time goes, there will be more and more iOS libraries being developed with dynamic Frameworks. currently, you need to use some nasty shell scripts to strip the non-ARM archs and then use some other nasty shells to sign the frameworks and finally, as @tuarua mentioned, you need to resign the .ipa again.

While the AIR-iOS-Packager is helping devs to speed up the process, it would be super great to see Adobe is doing all these things automatically in ADT to begin with.

@myflashlab
Copy link

As @PrimaryFeather suggested, I created the Feature Request in Adobe Tracker also here: https://tracker.adobe.com/#/view/AIR-4198408

@tuarua
Copy link
Author

tuarua commented Aug 4, 2017

AIR 27 beta now auto signs dynamic frameworks.
There are some project structural requirements.
See tracker for details.
https://tracker.adobe.com/#/view/AIR-4198407

@tuarua
Copy link
Author

tuarua commented Nov 18, 2017

Air 28 has resolved issues with creating a valid ipa for AppStore.
Swift 4 also support added.
Xcode 9 Simulator functioning correctly.

@Xgamefactory
Copy link

this issue not fixed completely i donT get why my comment was removed.
this hub to inform developers

@PrimaryFeather
Copy link
Contributor

Which comment was removed, @Xgamefactory?

@Xgamefactory
Copy link

Xgamefactory commented Apr 20, 2018

comment about that adobe air sdk still have issues signing ios third party dynamic frameworks

after codesing on mac adobe still cannot generate proper ipa as it try codesign and messed properly codesigned framework with error

=============================================================

  [MICodeSigningVerifier _validateSignatureAndCopyInfoForURL:withOptions:error:]: 147:  
    Failed to verify code signature of /private/var/installd/Library/Caches/..../Payload/Xt.....app/Frameworks/Mapbox.framework  
    : 0xe8008017 (A signed resource has been added, modified, or deleted.)  

=============================================================

i think best solution will be add a custom flag as -platformsdk to bypass codesining on adobe air side for dynamic third party frameworks.

adobe air ios sdk works as expected.

@Xgamefactory
Copy link

this codesign problem still exists on lates air sdk 29.122 win
i don't understand what adobe trying to do.
Looks like they are only interested in photoshop,illustrator and other design products or there are many insiders from opponent companies trying to ruin what left from macromedias development department.
Official adobe forum is abandoned,it took ages to get any reply from stuff.
All support stuff hired from lazy countries hanging out in office doing nothing. :)
There are left only few developers outside adobe who are trying to do something but without official support adobe air will get vanished like flash.
It is still best tool than xamarin,reactjs etc but with such terrible support air gets more unreliable each day.

@PrimaryFeather
Copy link
Contributor

Could you maybe create a new bug report on Adobe Tracker? Ideally with a small sample that showcases the problem? Adobe is probably not reviewing all the posts over here.

And don't forget to post the link here so we can vote for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants