-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplication of network definitions #315
Comments
There are a number of 10.x.x.x IP addresses that are are coded in the airshipctl function definitions. Those will need to be turned into placeholders or defaults, with replacement rules defined at the function level and exercised at the site level. The ironic provisioning_ip, dhcp_range, and provisioning_interface are currently patched at the site level in the ephemeral phase. We need to determine if that's good enough, or if we want to pull them out of e.g. common-networking catalogue (which is defined at type level, but can be overridden at site level) and/or the host catalogue. |
Deduplicate networking definitions inside of airshipctl functions, and make the values driveable via a catalogue. Changes: * Removed BMO patches at site level; drive through catalogue instead. * Added separate entrypoints for ephemeral & target site-level. catalogue/networking overrides. Ephemeral's kustomizes target's. * Generalized the commonHostNetworking catalogue into a section in the overall networking catalogue. * Cleaned up catalogue use in general. * Got rid of some ill-formed Type-level phase definition. We should go back soon and define proper Type-level phases. Change-Id: Iff96ccdcf7ebde4ae55e2b1a9d25dd1cdca0d2c8 Relates-To: #315
This adds network deduplication via variable catalogues and replacement. This was added to airshipctl under the change: https://review.opendev.org/#/c/749611/ Change-Id: Ib6a50c58e3b62de4f74c5def58b94ab6dbd1e949 Closes: airshipit/airshipctl#315
This is complete with the Treasuremap change that has merged here: https://review.opendev.org/#/c/753684/ |
Problem description (if applicable)
As an operator, I need the ability to specify common networking information at various levels of specificity while also being able to override & specify specific values down to the site & sub-type level.
The different levels of specificity could be:
Proposed change
This issue requires some level of design/investigation to determine the following
Samples can be found here:
https://review.opendev.org/#/c/735033/25/manifests/site/test-site/shared/catalogues/hosts.yaml
https://review.opendev.org/#/c/735033/25/manifests/type/gating/shared/catalogues/common-networking.yaml
The text was updated successfully, but these errors were encountered: