-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate post-beta release approach #354
Comments
Ideally we wouldn't have to maintain our own release notes generation code etc, here is an example: https://github.com/fluxcd/toolkit/blob/master/.github/workflows/release.yaml |
It looks like the github bot is not working, here is the implementation for release notes generation: Next steps for the release workflow would be:
|
@seaneagan this looks nice. I see that this release has all the issues we had since the start? Will next releases contain only delta issues? |
@teoyaomiqui yes, it will diff against the previous tag when one exists |
When a new tag is pushed (and mirrored to github), this github action generates release notes, and creates a draft release which can be published via the github UI after any manual verification or edits. An example draft release, generated using act [0] is available for review for those with sufficient access: https://github.com/airshipit/airshipctl/releases This could be extended in the future to accomplish other release tasks: - add version-tagged image to quay - integrate with goreleaser[1] (publish go binaries) - publish documentation [0]: https://github.com/nektos/act [1]: https://goreleaser.com Change-Id: Iedb70b0c330df0356fa74d94c1d4a45c3343cc2e Relates-To: #354 Closes: #390
A [Related Change](https://review.opendev.org/762714 was merged. This issue may be ready to close. |
Here are the instructions on how to create a tag: https://docs.opendev.org/opendev/infra-manual/latest/drivers.html#tagging-a-release You need to be in this group to have permissions to push the tag: https://review.opendev.org/admin/groups/1914,members Once the related automation patchsets all merge, I will create a |
Related Change #780940Subject: Fix calculation of previous tag for release notes gen ApprovalsCode-Review
+2 Kostyantyn Kalynovskyi
+2 Drew Walters
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Drew Walters Last Updated: 2021-03-17 12:59:03 CDT |
The gren tool uses the git tag history to calculate the previous tag to diff against. By default, the checkout action doesn't fetch the tag history, this configures it to do so [1]. [0]: https://github-tools.github.io/github-release-notes/options.html#tags [1]: https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches Relates-To: #354 Change-Id: I90fb4deecba842517945707a12e3b1bde2610f74 Signed-off-by: Sean Eagan <seaneagan1@gmail.com>
Semver release automation is almost complete for airshipctl and krm functions, everything in the this (airshipctl) repo. Open questions:
Not yet at least. Would like to work toward airshipctl CLI stability, manifest stability will be more difficult.
yes for treasuremap, images, charts, HCO, others?
We want to try to branch each repo in sync with each other
We want to start everything at 2.0.0 Edit: These were discussed in the 3/23 design call, notes added above |
The release automation flow for:
is complete for everything in this repo (airshipctl, krm functions). Let's open github issues for any other repos (see above) that we want this automation in. In the 3/23 design call i think we landed on the following release process: Minor release (v2.x.0)
Patch release (v2.x.y)
Assumption is we can do on-demand branching for sub-projects (when patches are needed). |
Closing per above comment. |
Need to investigate and propose an approach for releasing airship 2.0 code post-beta release.
Can possibly look at what cluster-api does for their releases:
The text was updated successfully, but these errors were encountered: