Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keepalived VRRP for K8s Ingress over host management/OAM interface #94

Closed
onlysource opened this issue Feb 19, 2021 · 7 comments
Closed

Keepalived VRRP for K8s Ingress over host management/OAM interface #94

onlysource opened this issue Feb 19, 2021 · 7 comments
Assignees
@manojkva
Labels
enhancement New feature or request ready for review Patchset(s) related to this issue are ready to be reviewed size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Milestone
v2.0

Comments

@onlysource
Copy link

Problem description (if applicable)
Network Cloud

Proposed change
Currently, k8s service-vips are dependent on CNI to announce over BGP. Moving away this service-vip to the management (OAM) interface could be ideal, eliminating any CNI dependency. The service-vips can be configured as floating-ip between all K8s master nodes, with VRRP.

Potential impacts
Potential security or performance related impacts.
@onlysource onlysource added enhancement New feature or request triage labels Feb 19, 2021
@jezogwza jezogwza changed the title Keepalived VRRP for K8s Ingress and MaaS service-VIPs over host management/OAM interface Keepalived VRRP for K8s Ingress and MaSS service-VIPs over host management/OAM interface Feb 24, 2021
@jezogwza jezogwza added this to the v2.0 milestone Feb 24, 2021
@jezogwza jezogwza added design needed Requires design approach/discussion and removed triage labels Feb 24, 2021
@eak13 eak13 changed the title Keepalived VRRP for K8s Ingress and MaSS service-VIPs over host management/OAM interface Keepalived VRRP for K8s Ingress over host management/OAM interface Feb 24, 2021
@manojkva
Copy link
Contributor

Please assign to me. Thanks

@eak13
Copy link

eak13 commented Mar 1, 2021

@manojkva all yours. Please make sure you provide a t-shirt size once you have a chance to take a look & we'll update. Thanks!

@lb4368 lb4368 added the size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]] label Mar 8, 2021
@michaelfix
Copy link

@manojkva - Manoj, per our Tech Dive today, are we close(r) to finishing this issue? Please lean in to ensure we close this issue ASAP.

@manojkva
Copy link
Contributor

Review ready PS = https://review.opendev.org/c/airship/treasuremap/+/778953

@eak13 eak13 added ready for review Patchset(s) related to this issue are ready to be reviewed and removed design needed Requires design approach/discussion labels Mar 18, 2021
airshipbot pushed a commit that referenced this issue Mar 25, 2021
@manojkva
Support for VRRP keepalived for Ingress
5ef460d 
- Added function/k8scontrol-ha
- Updated type/airship-core/controlplane to point to treasuremap
  function
- added networking-ha VariableCatalogue to treasuremap-base-catlg
Issue #94

Change-Id: I5a1ea545a01f59cd2213c375e42dcbca34bbad22
@michaelfix
Copy link

michaelfix commented Mar 26, 2021 •
edited
Loading

PS https://review.opendev.org/c/airship/treasuremap/+/778953 has been merged. @ak3216 , @manojkva can this issue be closed?

@manojkva
Copy link
Contributor

Yes. It could be closed.

@eak13
Copy link

eak13 commented Mar 26, 2021

Closing per above

@eak13 eak13 closed this as completed Mar 26, 2021
@eak13 eak13 mentioned this issue Mar 30, 2021
Closed
airshipbot pushed a commit that referenced this issue Apr 5, 2021
@manojkva
Fix for VRRP preKubeadmcommand list concatenating to a single line
0379b7f 
The following construct in #94 fix using patchesJsonMerge
- op: add
  path:  "/spec/kubeadmConfigSpec/preKubeadmCommands/-"
  value:
      apt-get update && apt-get install -y bridge-utils keepalived ipset ipvsadm
      systemctl enable --now keepalived

This leads to the prekubeadmcommand listed as a single line.

This PS fixes this issue. Also airshipctl #10 needs all system
updates/intall to be moved to Imagebuilder.

Closes: #212
Change-Id: I624de71d2009178670291dc82bd55824ce59e18d
airshipbot pushed a commit that referenced this issue Apr 26, 2021
@manojkva
Fix for VRRP preKubeadmcommand list concatenating to a single line
e9c0a67 
The following construct in #94 fix using patchesJsonMerge
- op: add
  path:  "/spec/kubeadmConfigSpec/preKubeadmCommands/-"
  value:
      apt-get update && apt-get install -y bridge-utils keepalived ipset ipvsadm
      systemctl enable --now keepalived

This leads to the prekubeadmcommand listed as a single line.

This PS fixes this issue. Also airshipctl #10 needs all system
updates/intall to be moved to Imagebuilder.

Closes: #212
Change-Id: I624de71d2009178670291dc82bd55824ce59e18d
@eak13 eak13 mentioned this issue Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manojkva manojkva

Labels
enhancement New feature or request ready for review Patchset(s) related to this issue are ready to be reviewed size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
6 participants
@manojkva @onlysource @lb4368 @michaelfix @eak13 @jezogwza