Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing from a git branch is broken #1395

Closed
ngoldbaum opened this issue Apr 10, 2024 · 0 comments · Fixed by #1413
Closed

Installing from a git branch is broken #1395

ngoldbaum opened this issue Apr 10, 2024 · 0 comments · Fixed by #1413

Comments

@ngoldbaum
Copy link

ngoldbaum commented Apr 10, 2024

If I specify a URL to install from with a branch specified with @, the correct branch is not installed.

When I make the following modification to numpy's asv config:

diff --git a/benchmarks/asv.conf.json b/benchmarks/asv.conf.json
index 7c7542b1ec..db5c89665a 100644
--- a/benchmarks/asv.conf.json
+++ b/benchmarks/asv.conf.json
@@ -46,7 +46,7 @@
     // list indicates to just test against the default (latest)
     // version.
     "matrix": {
-        "Cython": [],
+        "git+https://github.com/lysnikolaou/cython.git@nogil-build-flags": [],
         "build": [],
         "packaging": []
     },

Then instead of building that branch it builds the default branch.

I added some breakpoints to util.py and it looks like the regex logic in ParsedPipDeclaration doesn't account for this case and the branch is parsed as the package name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant