BUG,MAINT: Depend on build
#1387
Conversation
Set the project builder accordingly
HaoZeke
force-pushed
the
buildWithPip
branch
from
5269845
to
b59dc42
Compare
|
On whole I prefer supporting just |
HaoZeke
force-pushed
the
buildWithPip
branch
from
5569af5
to
2a68f94
Compare
ASV manages environments.
|
The ubuntu linux and macos runs are at 19 minutes, so the 30 minute limit for windows and PyPy should be upped to 60 minutes. |
Co-authored-by: mattip <mattip@users.noreply.github.com>
|
@mattip this should be fine now, the PyPy timeout is still random. |
|
PyPy has a timeout of 30 minutes, and the tests seem to take just about that. Why not up the timeout to 60 minutes? |
|
Or skip some of the slower tests on PyPy, like |
Yup, finally green. |
|
Thanks @HaoZeke |
| cmd = [ | ||
| "PIP_NO_BUILD_ISOLATION=0 python -m build", | ||
| "python -mpip wheel -w {build_cache_dir} {build_dir}" | ||
| ] |
There was a problem hiding this comment.
Why does this run wheel after running build, which would have already built a wheel?
Also, the call to build should probably pass --wheel, because I don't think the sdist is used for anything.
There was a problem hiding this comment.
Oh, I just remembered that pip wheel downloads wheels for dependencies as well, so I guess that's why it's used?
The problem seems to be that it says it's building the wheel again, which seems redundant (though it's not verbose, so I can't tell if it's just saying that or is really doing a whole build again.)
We are hitting odd
Run asv run --show-stderr --python 3.8 HEAD^-1
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'
which was presumably the
airspeed-velocity/asv#1385
which was addressed by
airspeed-velocity/asv#1387
which was released in 0.6.3 but we are installing it
Collecting asv!=0.6.2 (from asv[virtualenv]!=0.6.2)
Downloading asv-0.6.3-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.8 kB)
and still hitting it. Trying now with explicit "build" in depends
Closes #1385.