Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator to Signature struct #265

Merged
merged 10 commits into from
Nov 4, 2019
Merged

add validator to Signature struct #265

merged 10 commits into from
Nov 4, 2019

Conversation

poiresel
Copy link
Contributor

@poiresel poiresel commented Nov 4, 2019

Description

Quick description:

  • New features

#228

Changes

Core change: addition of validator to Types.sol

  struct Signature {
    address signatory;            // Address of the wallet used to sign
    address validator;            // Address of the intended swap contract
    bytes1 version;               // EIP-191 signature version
    uint8 v;                      // `v` value of an ECDSA signature
    bytes32 r;                    // `r` value of an ECDSA signature
    bytes32 s;                    // `s` value of an ECDSA signature
  }

Smaller changes

Upgrade package.json versions that weren't initially upgraded
Remove NULL_ADDRESS constant usage as it does not exist

Tests

##Test Coverage

@poiresel poiresel marked this pull request as ready for review November 4, 2019 19:03
Copy link
Contributor

@ejwessel ejwessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Defaulting to Alice for final approval.

@poiresel poiresel changed the title added swapContract to getOrder add validator to Signature struct Nov 4, 2019
Copy link
Contributor

@dmosites dmosites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants