Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version to 0.4.0 and update docs #1171

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Update version to 0.4.0 and update docs #1171

merged 3 commits into from
Jan 25, 2024

Conversation

kumaranvpl
Copy link
Contributor

@kumaranvpl kumaranvpl commented Jan 25, 2024 •
edited
Loading

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

davorrunje
davorrunje requested changes Jan 25, 2024
View reviewed changes
docs/docs/en/confluent/index.md Outdated

Please run the following command to install it:

```bash
pip install "faststream[confluent]==0.4.0rc0"
pip install "faststream[confluent]>=0.4.0rc0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We introduced the feature in rc, shall I change it to just version 0.4.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it now to 0.4.0

davorrunje
davorrunje previously approved these changes Jan 25, 2024
View reviewed changes
@davorrunje davorrunje added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@kumaranvpl kumaranvpl added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@davorrunje davorrunje added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@kumaranvpl kumaranvpl added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 66b4d95 Jan 25, 2024
30 checks passed
@kumaranvpl kumaranvpl deleted the update-version-to-0.4.0 branch January 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaranvpl @davorrunje