Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear_screen parameter #124

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add clear_screen parameter #124

merged 2 commits into from
Apr 25, 2024

Conversation

aisk
Copy link
Owner

@aisk aisk commented Apr 25, 2024

In #95 we added a position parameter to allow users to specify the position to show the options. And we didn't call screen.clear() with that change. But in some use cases, like #123, users do expect that the screen should be cleared.

At first, I thought we could use None as the default value for the position parameter and in this case, we could call screen.clear(). But then I realized that the position argument shouldn't be coupled with whether we should call screen.clear(). Someone might just want to show the options in the middle of the screen, and they still want the screen to be cleared.

So I decided to add a new parameter clear_screen to change the behavior, and the default value for clear_screen is True to maintain compatibility.

@Cornelius-Figgle, does this satisfy your original requirements?

@aisk aisk changed the title Allow clear screen Add clear_screen parameter Apr 25, 2024
@Cornelius-Figgle
Copy link
Contributor

@Cornelius-Figgle, does this satisfy your original requirements?

Yes this sounds good👍 It maintains the original function of pick but provides the option to not clear it/start at a specified position

@aisk aisk merged commit bec6a5c into master Apr 25, 2024
30 checks passed
@aisk aisk deleted the clear-screen branch April 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants