Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #95 we added a
position
parameter to allow users to specify the position to show the options. And we didn't callscreen.clear()
with that change. But in some use cases, like #123, users do expect that the screen should be cleared.At first, I thought we could use
None
as the default value for theposition
parameter and in this case, we could callscreen.clear()
. But then I realized that theposition
argument shouldn't be coupled with whether we should callscreen.clear()
. Someone might just want to show the options in the middle of the screen, and they still want the screen to be cleared.So I decided to add a new parameter
clear_screen
to change the behavior, and the default value forclear_screen
isTrue
to maintain compatibility.@Cornelius-Figgle, does this satisfy your original requirements?