Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch utilities #363

Closed
wants to merge 41 commits into from
Closed

Torch utilities #363

wants to merge 41 commits into from

Conversation

yoshipon
Copy link
Collaborator

@yoshipon yoshipon commented Apr 7, 2024

Add later...

@yoshipon yoshipon changed the title Torch utilities draft: Torch utilities Apr 20, 2024
@yoshipon yoshipon changed the title draft: Torch utilities Torch utilities Apr 20, 2024
@yoshipon yoshipon marked this pull request as draft April 20, 2024 09:08
yoshipon and others added 5 commits April 30, 2024 16:26
@yoshipon
Update error messages!
2c95787
@yoshipon
Merge branch 'feature/v2-torch' of github.com:aistairc/aiaccel into f…
c8aeabb 
…eature/v2-torch
@yoshipon
Update hdf5_dataset to take grp_list as argument
9d0f50a
@yoshipon
sort grp_list
649adc0
@aramoto99 @KanaiYuma-aist @yoshipon
update v2 torch (#383)
0caccda 
* Add nelder-mead sampler (#346)

* add nelder_mead_sampler.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add -e. (#371)

* Support for suggest_int in neldermead sampler. (#373)

* Support for suggest_int.

* Fix for ruff.

* Add Job dispatcher (#360)

* Update aiaccel/job

* fix lint error

* fix aiaccel/job/dispatcher.py

* wip

* Fix issues pointed out in review

* rename

* fix test

* fix for test

* fix for test

* fix for test

* fix for test

* Reflected code review feedback

* fix test

* fix test

* refactoring

* Run code formatter ruff

* refactoring

* Run code formatter ruff

* fix lint.yaml

* fix pypoject.toml

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* Refactor abci jobs

* Update pyproject.toml

* adjusted to work in the ABCI environment.

* fix lint error

* fix test

* fix test

* Changed from unittest to pytest

* Incorporate revisions based on review feedback

* Add test items

* fix test

* fix test

* fix test

* remove __future__.annotations

* A bit simplify qstat_xml

* Simplify tests

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add ignore_missing_imports. (#376)

* Draft Implementation of CLI Command (#369)

* Update aiaccel/job

* fix lint error

* fix aiaccel/job/dispatcher.py

* wip

* Fix issues pointed out in review

* rename

* fix test

* fix for test

* fix for test

* fix for test

* fix for test

* Reflected code review feedback

* fix test

* fix test

* refactoring

* Run code formatter ruff

* refactoring

* Run code formatter ruff

* fix lint.yaml

* fix pypoject.toml

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* Refactor abci jobs

* Update pyproject.toml

* adjusted to work in the ABCI environment.

* fix lint error

* fix test

* fix test

* Changed from unittest to pytest

* Incorporate revisions based on review feedback

* Add test items

* Add 'start.py'

* Fix code format

* update pyproject.toml

* Remove unnecessary items from config

* Add random seed option

* Refactor examples/start.py into aiaccel/apps/optimize.py

* fix lint errors and warnings

* remove apps/config

* fix typo

* change config.yaml format

* fix apps/optimizer

* fix HparamManager __init__

* fix HparamsManager

* Refactor Suggest class to use generics for improved type safety

* auto fix by ruff

* add optuna suggest wrapper

* format fix

* Update wrapper.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add nm docstring and move file (#381)

* Add docstring.

* Move nelder_mead_sampler.py.

* Fix path.

* Move test files.

* autoformat and fix mypy error

* Add v2 torch docstring   (#384)

* add docstring

* Update abci_environment.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

---------

Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com>
Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
@yoshipon yoshipon marked this pull request as ready for review August 26, 2024 18:54
@yoshipon
Copy link
Collaborator Author

@aramoto99 ご対応ありがとうございました。
v2-torchと関係のないコミットが混ざっているようなので、整理お願いします。

aramoto99 and others added 19 commits September 2, 2024 16:41
@aramoto99
Add torch goodies
16335e5
@yoshipon @aramoto99
Add type annotations
647182e
@aramoto99
Add small things
c2f6378
@yoshipon @aramoto99
update for mypy
057fe4c
@yoshipon @aramoto99
Add several tests
3c95d32
@aramoto99
add test for hdf5_dataset.py
950b44d
@yoshipon @aramoto99
Update workflows
e2a945d
@yoshipon @aramoto99
Add tests
40051bf
@yoshipon @aramoto99
update workflows
9e3e8c8
@aramoto99
add dependencies
cbc509d
@yoshipon @aramoto99
update train.py
ced8ff5
@yoshipon @aramoto99
add opt_lightning_module
854de3d
@yoshipon @aramoto99
Update error messages!
c05d5be
@aramoto99
add opt_lightning_module
c0b3fd9
@yoshipon @aramoto99
Update hdf5_dataset to take grp_list as argument
79c442d
@yoshipon @aramoto99
sort grp_list
d05c39e
@aramoto99 @KanaiYuma-aist @yoshipon
update v2 torch (#383)
798d4ba 
* Add nelder-mead sampler (#346)

* add nelder_mead_sampler.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add -e. (#371)

* Support for suggest_int in neldermead sampler. (#373)

* Support for suggest_int.

* Fix for ruff.

* Add Job dispatcher (#360)

* Update aiaccel/job

* fix lint error

* fix aiaccel/job/dispatcher.py

* wip

* Fix issues pointed out in review

* rename

* fix test

* fix for test

* fix for test

* fix for test

* fix for test

* Reflected code review feedback

* fix test

* fix test

* refactoring

* Run code formatter ruff

* refactoring

* Run code formatter ruff

* fix lint.yaml

* fix pypoject.toml

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* Refactor abci jobs

* Update pyproject.toml

* adjusted to work in the ABCI environment.

* fix lint error

* fix test

* fix test

* Changed from unittest to pytest

* Incorporate revisions based on review feedback

* Add test items

* fix test

* fix test

* fix test

* remove __future__.annotations

* A bit simplify qstat_xml

* Simplify tests

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add ignore_missing_imports. (#376)

* Draft Implementation of CLI Command (#369)

* Update aiaccel/job

* fix lint error

* fix aiaccel/job/dispatcher.py

* wip

* Fix issues pointed out in review

* rename

* fix test

* fix for test

* fix for test

* fix for test

* fix for test

* Reflected code review feedback

* fix test

* fix test

* refactoring

* Run code formatter ruff

* refactoring

* Run code formatter ruff

* fix lint.yaml

* fix pypoject.toml

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* fix mypy.ini

* Refactor abci jobs

* Update pyproject.toml

* adjusted to work in the ABCI environment.

* fix lint error

* fix test

* fix test

* Changed from unittest to pytest

* Incorporate revisions based on review feedback

* Add test items

* Add 'start.py'

* Fix code format

* update pyproject.toml

* Remove unnecessary items from config

* Add random seed option

* Refactor examples/start.py into aiaccel/apps/optimize.py

* fix lint errors and warnings

* remove apps/config

* fix typo

* change config.yaml format

* fix apps/optimizer

* fix HparamManager __init__

* fix HparamsManager

* Refactor Suggest class to use generics for improved type safety

* auto fix by ruff

* add optuna suggest wrapper

* format fix

* Update wrapper.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

* Add nm docstring and move file (#381)

* Add docstring.

* Move nelder_mead_sampler.py.

* Fix path.

* Move test files.

* autoformat and fix mypy error

* Add v2 torch docstring   (#384)

* add docstring

* Update abci_environment.py

---------

Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>

---------

Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com>
Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
@aramoto99
fix confrict
90f3f3e
@aramoto99
Merge branch 'feature/v2-torch--patch2--' into feature/v2-torch
3594780
@yoshipon yoshipon closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramoto99 aramoto99 Awaiting requested review from aramoto99

@KanaiYuma-aist KanaiYuma-aist Awaiting requested review from KanaiYuma-aist

Assignees

@aramoto99 aramoto99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshipon @aramoto99