Show an error when project is not supplied #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rominf
force-pushed
the
rominf-fix-246
branch
from
5a54571
to
c8630b9
Compare
akudiyar
previously requested changes
Dec 23, 2021
rominf
force-pushed
the
rominf-fix-246
branch
2 times, most recently
from
7594a11
to
fed6425
Compare
rominf
force-pushed
the
rominf-fix-246
branch
3 times, most recently
from
f108ada
to
18baf68
Compare
Fix #246 The result of `get_project` is `None` if user didn't login, and specifies `--auth-token`. Check and raise an exception.
rominf
force-pushed
the
rominf-fix-246
branch
from
18baf68
to
c7f6417
Compare
|
I approve these changes, although I suggest starting to make more functional tests for the client CLI, like it is done for admin CLI, for example. |
akudiyar
approved these changes
Dec 27, 2021
rominf
pushed a commit
that referenced
this pull request
Jan 17, 2022
#247 introduced a bug: an error about a missing project was raised even if the project was optional. This change fixes this by splitting get_project to get_non_none_project and get_project.
rominf
pushed a commit
that referenced
this pull request
Jan 17, 2022
#247 introduced a bug: an error about a missing project was raised even if the project was optional. This change fixes this by splitting get_project to get_non_none_project and get_project.
rominf
pushed a commit
that referenced
this pull request
Jan 17, 2022
#247 introduced a bug: an error about a missing project was raised even if the project was optional. This change fixes this by splitting get_project to get_non_none_project and get_project.
rominf
pushed a commit
that referenced
this pull request
Jan 17, 2022
#247 introduced a bug: an error about a missing project was raised even if the project was optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change: What it does, why it matters
Fix #246
The result of
get_projectisNoneif user didn't login, and specifies--auth-token. Check and raise an exception.