Do not raise an error about the missing project in non-auth commands #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rominf
force-pushed
the
rominf-get_non_none_project
branch
2 times, most recently
from
0118533
to
f99d68f
Compare
#247 introduced a bug: an error about a missing project was raised even if the project was optional.
rominf
force-pushed
the
rominf-get_non_none_project
branch
from
f99d68f
to
9e3131b
Compare
dmitrii-vasilev
requested changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#247 introduced a bug: an error about a missing project was raised even if the project was optional.
This change fixes this by splitting get_project to get_non_none_project and get_project.