-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/scr info expose error msg #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imda-amdlahir
temporarily deployed
to
internal
January 15, 2024 00:28
— with
GitHub Actions
Inactive
imda-amdlahir
requested review from
imda-benedictlee,
imda-kelvinkok and
kimeetok
and removed request for
imda-kelvinkok
January 15, 2024 00:29
imda-benedictlee
previously approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
kimeetok
previously approved these changes
Jan 16, 2024
imda-amdlahir
dismissed stale reviews from kimeetok and imda-benedictlee
via
January 18, 2024 09:29
44a81b3
imda-amdlahir
temporarily deployed
to
internal
January 18, 2024 09:29
— with
GitHub Actions
Inactive
imda-amdlahir
temporarily deployed
to
internal
January 18, 2024 09:46
— with
GitHub Actions
Inactive
imda-benedictlee
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
Smoke Test For Docker Passed |
kimeetok
approved these changes
Jan 18, 2024
Pipeline Test for Docker Passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of SCR fixes -
Type of Change
How to Test
This changes do not impact any existing features. It is just changing the error output when exceptions are caught in graphql resolvers.
Checklist
Please check all the boxes that apply to this pull request using "x":
Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]
Developer Certificate of Origin