Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text can be blurry after scrolling #4328

Closed
1 of 3 tasks
lid opened this issue Jun 27, 2020 · 8 comments · Fixed by #4338
Closed
1 of 3 tasks

Text can be blurry after scrolling #4328

lid opened this issue Jun 27, 2020 · 8 comments · Fixed by #4338

Comments

@lid
Copy link

lid commented Jun 27, 2020

Type of issue (choose one):

  • Bug
  • Feature request
  • Question

Description

After scrolling in either Ace Kitchen Sink or Caret (a downstream project), the text sometimes appears to be more blurry, depending on where the scroll is stopped. Other code editors (e.g. CodePad) and webviews do not exhibit this behavior. Could this be the result of an undesirable antialiasing behavior?

Before scrolling:
not-blurry

After scrolling:
blurry

Additional notes

Originally filed downstream: https://github.com/thomaswilburn/Caret/issues/729
Potentially related issues: #3081, nos/client#376

System details

ChromeOS | 84.0.4147.64 (Official Build) beta (64-bit)

@nightwing
Copy link
Member

On windows similar issue was happening with because of css transform.

Could you try running require("ace/lib/dom").HI_DPI to see if ace is using css transforms or absolute positioning in this case.

@lid
Copy link
Author

lid commented Jul 5, 2020

> require("ace/lib/dom").HI_DPI
< true

@nightwing
Copy link
Member

@lid
Copy link
Author

lid commented Jul 5, 2020

Thanks for the quick attempt at a fix! However, the githack seems to be about the same, TBH.

Clear before scroll:
Clear before scroll

Blurry after scroll:
Blurry after scroll

@nightwing
Copy link
Member

could you also run require("ace/lib/dom").HI_DPI again to see if the change have actually switched it to false?

@lid
Copy link
Author

lid commented Jul 5, 2020

I'm afraid it didn't change on githack, I get the same console result:

> require("ace/lib/dom").HI_DPI
< true

@nightwing
Copy link
Member

Thanks, could you try if http://raw.githack.com/ajaxorg/ace/4e96653032f248a87d879d7d28cddd5e196d6ecf/kitchen-sink.html fixes the issue
and if it doesn't what is the output of window.devicePixelRatio and require("ace/lib/useragent").isChromeOS

@lid
Copy link
Author

lid commented Jul 7, 2020

It's fixed with that latest githack! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants