Ios keyboard #3310
Merged
Ios keyboard #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartcl
reviewed
Jun 11, 2017
| } | ||
| event.addListener(text, "compositionend", onCompositionEnd); | ||
|
|
||
| this.getElement = function() { |
There was a problem hiding this comment.
For this entire block: could you reorder the code a bit so we don't interleave function and member declarations and initialization code too much?
There was a problem hiding this comment.
i'll do this when refactoring textinput.js, i want to keep these files in sync to be able to easily merge them in the future.
| }, 100); | ||
| }); | ||
|
|
||
| // IOS doesn't fire events for arrow keys, but this unique hack changes everything! |
There was a problem hiding this comment.
This sounds like clickbait :D
|
@nightwing also please make sure to update #3172 if this is merged |
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lennartcl this is the rebased version of https://github.com/ajaxorg/ace/pull/3172、i've kept ios textinput in a separate file for now, since textinput already has too many code paths