workaround for delayed mouseup event from touchpads #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I fully understand the solution, are there any downsides to this? |
|
The proposed solution is to stop mouse selection, when editor command is invoked, so if mouse is pressed, and user presses ctrl-a, or some other key, mouse movements will stop changing the selection. This matches with the behavior of sublime text and monaco, and i couldn't find bug reports related to this behavior. Only potential issue i can see is pressing ctrl-c and wanting to continue the selection, but as a workaround for that we can release mouse only if selection changes during the command. |
|
I see. Thanks. I tested the approach. LGTM. |
lennartcl
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround for #3471
also matches with the behavior of other online code editors and sublime text