Change image link highlighting for mode-markdown #3667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
requested changes
May 14, 2018
| @@ -110,6 +110,14 @@ var MarkdownHighlightRules = function() { | |||
| }, { // link by reference | |||
| token : ["text", "string", "text", "constant", "text"], | |||
| regex : "(\\[)(" + escaped("]") + ")(\\]\s*\\[)("+ escaped("]") + ")(\\])" | |||
| }, { // link image | |||
| token : ["text", "string", "text", "markup.underline", "string", "text"], | |||
| regex : "(\\!\\[)(" + // 
|
I'm not sure what happened here - looks like I accidentally linked upstream to an old build rather than the forked copy I'd pulled yesterday. Anyway it'll be easier to just resubmit a clean version. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image link highlighting in mode-markdown seems to not highlight the leading
!character. In some cases this looks OK in others maybe not so much. I think it's probably better to have the entire image formatting use the same colors.Added in explicit image link handling.
This is what it looks like before:
and here it is after the change:
The latter seems more consistent.
To be honest this is minor but several of my users have mentioned this (here's one) and looking at the two renderings side by side I do think that the latter looks more consistent.