fix error when destroying editor in iframe #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ace/lib/event.js
Outdated
| @@ -108,18 +108,19 @@ exports.getButton = function(e) { | |||
| }; | |||
|
|
|||
| exports.capture = function(el, eventHandler, releaseCaptureHandler) { | |||
| var doc = el && el.ownerDocument || document; | |||
There was a problem hiding this comment.
If I expand doc then it becomes document, but the document variable already exists. What's the difference between doc and document and can you reflect that in the name of doc ?
nightwing
force-pushed
the
fix-mousehandler-destroy
branch
from
b9267f8
to
e8babcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4330 +/- ##
==========================================
+ Coverage 71.92% 72.03% +0.11%
==========================================
Files 536 536
Lines 52245 52300 +55
Branches 9730 9738 +8
==========================================
+ Hits 37575 37676 +101
+ Misses 14670 14624 -46
Continue to review full report at Codecov.
|
keyboardDrummer
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes error thrown if destroy is called while mouse is pressed, or when captureEnd was not fired because of iframe