Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues #4339

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Fix small issues #4339

merged 2 commits into from
Jul 7, 2020

Conversation

nightwing
Copy link
Member

fixes #4336 and #4329

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #4339 into master will decrease coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
- Coverage   72.04%   70.48%   -1.56%     
==========================================
  Files         536      536              
  Lines       52304    54186    +1882     
  Branches     9739    10198     +459     
==========================================
+ Hits        37680    38193     +513     
- Misses      14624    15993    +1369     
Flag Coverage Δ
#unittests 70.48% <100.00%> (-1.56%) ⬇️
Impacted Files Coverage Δ
lib/ace/mode/javascript/jshint.js 30.69% <ø> (-1.16%) ⬇️
lib/ace/tokenizer.js 95.56% <ø> (ø)
lib/ace/config.js 47.36% <100.00%> (ø)
lib/ace/mode/javascript_worker.js 87.50% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccda8c...53347eb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command pallete shows Win shortcuts when running on Mac
2 participants