Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setAnnotations could use custom className #4362

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

FavorMylikes
Copy link
Contributor

Example

.ace_gutter-cell.ace_my_class_name{
    background: darkorange no-repeat 2px center;
}
editor.session.setAnnotations([{
                            row: 0,
                            text: ["some message will show when mouse hover"],
                            className: "ace_error"  // show the error icon
                        }, {
                            row: 0,
                            text: ["other message"],
                            className: "ace_my_class_name"  // show the background color instead of the default icon
                        }])

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

### Example 
```css
.ace_gutter-cell.ace_my_class_name{
    background: darkorange no-repeat 2px center;
}
```
```js
inputEditor.session.setAnnotations([{
                            row: 0,
                            text: ["some message will show when mouse hover"],
                            className: "ace_error"  // show the error icon
                        }, {
                            row: 0,
                            text: ["other message"],
                            className: "ace_my_class_name"  // show the background color instead of the default icon
}])
```
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #4362 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
+ Coverage   70.48%   70.50%   +0.01%     
==========================================
  Files         537      539       +2     
  Lines       54196    54230      +34     
  Branches    10199    10200       +1     
==========================================
+ Hits        38202    38234      +32     
- Misses      15994    15996       +2     
Flag Coverage Δ
#unittests 70.50% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/layer/gutter.js 89.78% <75.00%> (-0.25%) ⬇️
lib/ace/mode/smithy.js 90.90% <90.90%> (ø)
lib/ace/mode/smithy_highlight_rules.js 100.00% <100.00%> (ø)
lib/ace/virtual_renderer.js 79.06% <100.00%> (ø)
lib/ace/range.js 85.51% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97afe3...3948937. Read the comment docs.

@andrewnester andrewnester merged commit f505879 into ajaxorg:master Jun 28, 2022
@FavorMylikes FavorMylikes deleted the patch-1 branch July 4, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants