Fix undefined error thrown when using soft wraps and RTL font #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `splits` variable
|
I don't think we have an active tracking issue for RTL support, we had something previously but it was closed due to inactivity Feel free to great one which describes the issues you see |
|
For you PR, could you please provide a reproduction steps to verify the fix? Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #4835 +/- ##
=======================================
Coverage 69.94% 69.94%
=======================================
Files 559 559
Lines 58338 58338
Branches 11235 11235
=======================================
Hits 40803 40803
Misses 17535 17535
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
N/A
Description of changes:
Our organization ran into an issue where we see an undefined error being thrown when users attempt to use RTL fonts in an editor with soft wraps enabled.
I found the offending line of code in the bidihandler.js file where there is a conditional that checks for truthiness of the
splitsvariable but then directly below/outside that block, the code attempts to accesssplits.lengthwithout first checking for truthiness.Side note: I've found the RTL functionality in Ace to be rather buggy with some weird indentations that appear when writing multiple lines using RTL mode + RTL font. Is there an issue that outlines the current state of support for RTL languages?