added github dark theme #5154
added github dark theme #5154
Conversation
src/theme/github_dark.css.js
Outdated
| .ace-github .ace_constant.ace_buildin { | ||
| color: #0086B3; | ||
| } | ||
|
|
||
| .ace-github .ace_support.ace_function { | ||
| color: #0086B3; | ||
| } | ||
|
|
||
| .ace-github .ace_comment { | ||
| color: #90bbe1; | ||
| font-style: italic; | ||
| } | ||
|
|
||
| .ace-github .ace_variable.ace_language { | ||
| color: #ffffff; | ||
| } |
There was a problem hiding this comment.
These lines here are for ace-github and not ace-github-dark and they seem to be duplicates from above, I think you forgot to remove these?
There was a problem hiding this comment.
Thank you for your feedback and for pointing out the duplicated lines in the code. You are correct that these lines were intended for ace-github and not ace-github-dark and I apologize for the oversight. I will remove these lines as soon as possible to ensure that the code is clean and efficient.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5154 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 560 560
Lines 44199 44199
Branches 6850 6850
=======================================
Hits 38312 38312
Misses 5887 5887
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue #, if available:
Github dark theme was added.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.