Fix tmTheme tool #5238
Fix tmTheme tool #5238
Conversation
|
sorry, this accidentally includes #5236 |
tool/tmtheme.js
Outdated
| callback(theme[0]) | ||
| }); | ||
| callback(parse(themeXml)); | ||
| // parseString(themeXml, function(_, theme) { |
There was a problem hiding this comment.
Can we remove these commented out old lines
I would love to, but I'm not an expert with git. Is there a non-destructive way for me to do this? I know I could rewrite the history of the repo, but I'm not sure of the effects on the PR and such. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5238 +/- ##
==========================================
+ Coverage 87.22% 87.24% +0.01%
==========================================
Files 565 565
Lines 45253 45284 +31
Branches 6927 6928 +1
==========================================
+ Hits 39471 39506 +35
+ Misses 5782 5778 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
In this case, easiest way is probably to just push a new commit to this branch on your fork where you delete the added lines to undo manager, then when we merge your PR, we will squash all your commits into a single commit on our master branch. I went ahead and cleaned up the PR for you. |
Issue #, if available: #5237
Description of changes: Update tmTheme tool to use non-deprecated plist.js methods
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.