Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSHint version to 2.13.6 #5243

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jul 6, 2023

Issue #, if available: #4756

Description of changes:

  • Update JSHint version to current latest
  • Change default option to target ECMAScript 11
  • Replace deprecated property esnext with esversion

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (c910951) 87.22% compared to head (923f0bb) 87.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5243      +/-   ##
==========================================
+ Coverage   87.22%   87.24%   +0.01%     
==========================================
  Files         565      565              
  Lines       45251    45283      +32     
  Branches     6927     6928       +1     
==========================================
+ Hits        39469    39505      +36     
+ Misses       5782     5778       -4     
Flag Coverage Δ
unittests 87.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

// https://underscorejs.org
// (c) 2009-2022 Jeremy Ashkenas, Julian Gonggrijp, and DocumentCloud and Investigative Reporters & Editors
// Underscore may be freely distributed under the MIT license.

// Current version.
var VERSION = '1.13.4';
var VERSION = '1.13.6';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit title it says 2.13.6 but here it says 1.13.6, is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just interesting coincidence. It's version of updated underscore package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, they are different packages all together that just coincidentally are on very similar version numbers, thx

@akoreman akoreman merged commit 301aee9 into ajaxorg:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using object spread property in Javascript mode, getting unexpected warning.
2 participants