-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro mode syntax highlighting #5269
Conversation
Thanks for your contribution, could you also add an example doc for the mode to the demo/kitchen-sink/docs folder and add it to the modelist in src/ext/modelist.js. For reference on what to add where, see PR #5169. |
@akoreman hey i've added a file to kitchen sink and also added in modelist . also made little change on the mode file |
Could you:
|
@akoreman try now |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5269 +/- ##
==========================================
- Coverage 87.23% 87.19% -0.04%
==========================================
Files 565 567 +2
Lines 45288 45351 +63
Branches 6929 6941 +12
==========================================
+ Hits 39508 39546 +38
- Misses 5780 5805 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
thanks for fixing the build errors, mode looks good to me. Could you add some tests covering the mode (see for example here for an example of tests for a mode) |
I don't think i can do this . Isn't it optional 😕 ? if it's needed then Can you do it 😅 |
The new Astro mode just inherits HTMLMode, so the tests for the mode itself are not really necessary. I'm merging this PR assuming one of the next mode-related PRs will regenerate tokens for highlight rule tests which will include Astro mode as well. |
Description of changes:
Syntax highlighting for Astro mode
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.